feat(tournaments-ticker): add new redesigned ticker with variants for AB testing#7303
Open
feat(tournaments-ticker): add new redesigned ticker with variants for AB testing#7303
Conversation
The tournament list ticker should always reset to Ongoing on page load. Removes syncLevel from ContentSwitch entirely and sets storeValue=false in the List widget so no tab state is persisted to localStorage.
mbergen
reviewed
Mar 27, 2026
mbergen
reviewed
Mar 27, 2026
mbergen
reviewed
Mar 27, 2026
mbergen
reviewed
Mar 30, 2026
mbergen
reviewed
Mar 30, 2026
Eetwalt
force-pushed
the
new-tournament-list
branch
from
fdf2e26 to
79e0ac2
Compare
mbergen
approved these changes
Mar 30, 2026
Rathoz
reviewed
Mar 30, 2026
Rathoz
reviewed
Mar 30, 2026
Comment on lines
+252
to
+258
| &.badge--tier4, | ||
| &.badge--tier5, | ||
| &.badge--misc, | ||
| &.badge--qualifier, | ||
| &.badge--monthly, | ||
| &.badge--weekly, | ||
| &.badge--showmatch { |
Collaborator
There was a problem hiding this comment.
Maybe just make the default? there are some wiki specified tiertypes
Collaborator
Author
There was a problem hiding this comment.
still need to override the tier4 and tier5 for top3 scheme with the gray as they will otherwise inherit the full scheme colors, but otherwise I made the gray default and removed the other tiertypes
Rathoz
reviewed
Mar 30, 2026
Comment on lines
+215
to
+219
| &.badge--misc, | ||
| &.badge--qualifier, | ||
| &.badge--monthly, | ||
| &.badge--weekly, | ||
| &.badge--showmatch { |
Collaborator
Author
|
@mbergen turns out the tournament logo needs to be wrapped in a class in the badges, so it doesn't render in darkmode automatically because of https://github.com/Liquipedia/Lua-Modules/blob/new-tournament-list/stylesheets/commons/Miscellaneous.scss#L393-L396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the redesigned tournament ticker for mainpages. We're rolling this out on a couple wikis first, so we're not going to replace the existing ticker before it's rolled out everywhere. This PR:
Widget/Tournaments/Ticker/Listwith a tab-based phase navigation variant (default) and a collapsible variant (AB test - will most likely settle for one)subtletier pill variant with configurablecolorScheme(full/top3) (Tier colors is AB test - will most likely settle for one)Widget/Tournaments/Ticker/DatamoduleChevronTogglefromWidget/Participants/Team/toWidget/GeneralCollapsible/for broader reuseNotes
stylesheets/commons/TournamentTags.scsshas hardcoded hex values. My thinking was doing the AB test like this, and make variables to skin when we settle on the approach to avoid double work.How did you test this change?
|dev=ntl4on the mainpages of wikis listed below + devtoolsVariants: